Skip to content

Type argument in scale_[fill/colour]_[continuous/binned] can accept a function #3828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 30, 2020
Merged

Type argument in scale_[fill/colour]_[continuous/binned] can accept a function #3828

merged 3 commits into from
Apr 30, 2020

Conversation

@cpsievert
Copy link
Contributor

See #3827

@hadley
Copy link
Member

hadley commented Feb 22, 2020

This seems reasonable to me.

@cpsievert cpsievert requested a review from thomasp85 February 22, 2020 00:46
@cpsievert cpsievert mentioned this pull request Feb 25, 2020
Merged
@cpsievert cpsievert mentioned this pull request Mar 6, 2020
Closed
thomasp85
thomasp85 approved these changes Mar 6, 2020
View reviewed changes
Copy link
Member

@thomasp85 thomasp85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasp85
Copy link
Member

@cpsievert can you add a small note in NEWS.md?

@cpsievert
Copy link
Contributor Author

@thomasp85 good to merge? Those build failures look like false positives

@thomasp85 thomasp85 merged commit 95ba60b into tidyverse:master Apr 30, 2020
@thomasp85
Copy link
Member

Thanks!

@cpsievert cpsievert mentioned this pull request May 19, 2020
Closed
@cpsievert cpsievert deleted the carson/feature/continuous-default-function branch June 23, 2020 14:42
@yutannihilation yutannihilation mentioned this pull request Jul 26, 2020
Open
@Seviks Seviks mentioned this pull request Sep 2, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thomasp85 thomasp85 thomasp85 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cpsievert @hadley @thomasp85